UI-07: rebuild Rides History with search, activity filter, and real ride thumbnails
Restyles TripsScreen toward Map HUD's GlassPanel language: a search bar and activity-filter dropdown, four distinct summary stat cards (replacing the mockup's four-identical-cards artifact), and per-ride RideMap thumbnails showing each ride's own recorded path instead of stock photos. RideHistorySummary is a pure function rather than a provider, since folding over an already-fetched trip list is cheap regardless of history length, and it makes the aggregation directly unit-testable. Average speed is distance-weighted across the whole history rather than averaging each ride's own average. Adds a showAttribution flag to RideMap (default true) to suppress the TileAttribution control on tiny list thumbnails, where it was both a UX problem and a test collision with each card's own activity icon. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Xki7YAcc2TiN2PRZJ2tXr
This commit is contained in:
43
test/ride_history_summary_test.dart
Normal file
43
test/ride_history_summary_test.dart
Normal file
@@ -0,0 +1,43 @@
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:rippr/src/domain/models.dart';
|
||||
import 'package:rippr/src/ui/trips/trips_screen.dart';
|
||||
|
||||
/// UI-07: `RideHistorySummary.compute` is a pure function specifically so it can be
|
||||
/// tested directly against a hand-computed total, rather than through a screen.
|
||||
void main() {
|
||||
test('compute matches a hand-computed total over a fixed set of trips', () {
|
||||
final trips = [
|
||||
const Trip(
|
||||
id: 1,
|
||||
startedAt: 0,
|
||||
endedAt: 3600000,
|
||||
distanceM: 20000,
|
||||
movingMillis: 3600000,
|
||||
),
|
||||
const Trip(
|
||||
id: 2,
|
||||
startedAt: 0,
|
||||
endedAt: 1800000,
|
||||
distanceM: 5000,
|
||||
movingMillis: 1800000,
|
||||
),
|
||||
];
|
||||
|
||||
final summary = RideHistorySummary.compute(trips);
|
||||
|
||||
expect(summary.rideCount, 2);
|
||||
expect(summary.totalDistanceM, 25000);
|
||||
expect(summary.totalMovingMillis, 5400000);
|
||||
// Distance-weighted, not an average of each ride's own average: 25 km over 1.5 h.
|
||||
expect(summary.avgSpeedKmh, closeTo(25 / 1.5, 0.0001));
|
||||
});
|
||||
|
||||
test('an empty history has zero average speed, not a division error', () {
|
||||
final summary = RideHistorySummary.compute(const []);
|
||||
|
||||
expect(summary.rideCount, 0);
|
||||
expect(summary.totalDistanceM, 0);
|
||||
expect(summary.totalMovingMillis, 0);
|
||||
expect(summary.avgSpeedKmh, 0);
|
||||
});
|
||||
}
|
||||
@@ -14,6 +14,7 @@ import 'package:rippr/src/recording/location_source.dart';
|
||||
import 'package:rippr/src/recording/wakelock_controller.dart';
|
||||
import 'package:rippr/src/ui/app_shell.dart';
|
||||
import 'package:rippr/src/ui/components/glass_panel.dart';
|
||||
import 'package:rippr/src/ui/components/ride_map.dart';
|
||||
import 'package:rippr/src/ui/detail/trip_detail_screen.dart';
|
||||
import 'package:rippr/src/ui/format.dart';
|
||||
import 'package:rippr/src/ui/record/record_screen.dart';
|
||||
@@ -493,8 +494,86 @@ void main() {
|
||||
|
||||
expect(find.byKey(const Key('trip-1')), findsOneWidget);
|
||||
expect(find.text('Finished'), findsOneWidget);
|
||||
// Only the completed one.
|
||||
expect(find.byType(Card), findsOneWidget);
|
||||
// Only the completed one. UI-07: trip cards are GlassPanel-based, not Card --
|
||||
// RideMap's thumbnail is unique to a trip card (unlike GlassPanel/Material, which
|
||||
// other chrome on this screen also uses).
|
||||
expect(find.byType(RideMap), findsOneWidget);
|
||||
});
|
||||
|
||||
screenTest('search narrows the visible list to matching rides (UI-07)',
|
||||
(tester) async {
|
||||
await seedCompletedTrip(
|
||||
startedAt: 1000, endedAt: 5000, name: 'Coast loop');
|
||||
await seedCompletedTrip(
|
||||
startedAt: 100000, endedAt: 200000, name: 'Mountain climb');
|
||||
|
||||
await tester.pumpWidget(host(const TripsScreen()));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
expect(find.text('Coast loop'), findsOneWidget);
|
||||
expect(find.text('Mountain climb'), findsOneWidget);
|
||||
|
||||
await tester.enterText(find.byKey(const Key('ride-search')), 'coast');
|
||||
await tester.pump();
|
||||
|
||||
expect(find.text('Coast loop'), findsOneWidget);
|
||||
expect(find.text('Mountain climb'), findsNothing);
|
||||
});
|
||||
|
||||
screenTest('filtering by activity narrows the visible list (UI-07)',
|
||||
(tester) async {
|
||||
await repo.startTrip(1000, activity: Activity.bicycle).then(
|
||||
(h) async {
|
||||
await repo.appendPoints([
|
||||
TrackPoint(
|
||||
tripId: h.tripId,
|
||||
segmentId: h.segmentId,
|
||||
timestamp: 1000,
|
||||
latitude: 51.0,
|
||||
longitude: -114.0,
|
||||
speedKmh: 20,
|
||||
altitudeM: 1000,
|
||||
),
|
||||
]);
|
||||
await repo.renameTrip(h.tripId, 'Bike ride');
|
||||
await repo.completeTrip(5000);
|
||||
await repo.recomputeAggregates(h.tripId);
|
||||
});
|
||||
await repo.startTrip(100000, activity: Activity.motorcycle).then(
|
||||
(h) async {
|
||||
await repo.appendPoints([
|
||||
TrackPoint(
|
||||
tripId: h.tripId,
|
||||
segmentId: h.segmentId,
|
||||
timestamp: 100000,
|
||||
latitude: 51.0,
|
||||
longitude: -114.0,
|
||||
speedKmh: 60,
|
||||
altitudeM: 1000,
|
||||
),
|
||||
]);
|
||||
await repo.renameTrip(h.tripId, 'Moto ride');
|
||||
await repo.completeTrip(200000);
|
||||
await repo.recomputeAggregates(h.tripId);
|
||||
});
|
||||
|
||||
await tester.pumpWidget(host(const TripsScreen()));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
expect(find.text('Bike ride'), findsOneWidget);
|
||||
expect(find.text('Moto ride'), findsOneWidget);
|
||||
|
||||
await tester.tap(find.byKey(const Key('activity-filter')));
|
||||
await tester.pump();
|
||||
await tester.pump(const Duration(milliseconds: 300));
|
||||
await tester.pump();
|
||||
await tester.tap(find.byKey(const Key('activity-filter-bicycle')));
|
||||
await tester.pump();
|
||||
await tester.pump(const Duration(milliseconds: 300));
|
||||
await tester.pump();
|
||||
|
||||
expect(find.text('Bike ride'), findsOneWidget);
|
||||
expect(find.text('Moto ride'), findsNothing);
|
||||
});
|
||||
|
||||
screenTest('Merge enables at exactly two selections', (tester) async {
|
||||
|
||||
Reference in New Issue
Block a user