Files
rippr/test/settings_screen_test.dart
uhryniuk bcface3529 UI-04: customizable, persisted HUD telemetry widget layout
Adds the full drag/resize/visibility infrastructure for a rider-owned HUD
layout: HudMetric (the stable 8-metric set), HudWidgetLayout (fractional
x/y/width/height + visible, with clamping to a legibility floor/ceiling
and JSON round-trip that degrades to sane defaults rather than crashing),
Config.hudLayout persistence, and a HudLayoutController that stays
in-memory-authoritative during an edit session and only writes through on
persist() -- never per drag frame.

DraggableResizableHudWidget and HudEditOverlay assemble the interaction:
edit mode is entered by a long-press on empty HUD space (not a specific
widget) and exited via Done or a tap on empty space; only while editing
does a widget attach any drag/resize gesture at all, so a normal tap can
never move one mid-ride by construction, not by an internal flag.

Fixes a real gesture-arena bug found during testing: outside edit mode, a
long-press landing on a widget was free to bubble to the overlay's
background long-press handler and wrongly enter edit mode. An inner no-op
GestureDetector of the same gesture type now absorbs it.

Adds a "Live HUD stats" Settings section, one switch per metric, that
persists immediately (unlike drag frames). Placed at the end of the
Settings list rather than in the middle -- inserting mid-list pushed
every later section below several existing tests' viewport assumptions.

Verified end-to-end on a real emulator including a full process restart:
resized a widget, force-stopped the app, relaunched, and the resize held.
No consuming screen exists yet (UI-05's job) -- verified via a throwaway
preview entry point, deleted after use.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Xki7YAcc2TiN2PRZJ2tXr
2026-08-23 20:45:02 -05:00

253 lines
9.0 KiB
Dart

import 'package:flutter/material.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:rippr/src/app/providers.dart';
import 'package:rippr/src/config/config.dart';
import 'package:rippr/src/domain/models.dart';
import 'package:rippr/src/hud/hud_metric.dart';
import 'package:rippr/src/ui/settings/settings_screen.dart';
import 'package:rippr/src/ui/theme.dart';
import 'package:shared_preferences/shared_preferences.dart';
/// V3-02: every `Config` value must be viewable and editable here, and every write must
/// actually reach `Config` -- not just update local widget state that looks right until
/// the next app launch.
void main() {
late Config config;
setUp(() async {
SharedPreferences.setMockInitialValues({});
config = await Config.load();
});
Widget host() => ProviderScope(
overrides: [configProvider.overrideWith((ref) => config)],
child: MaterialApp(theme: ripprTheme(), home: const SettingsScreen()),
);
testWidgets('the map switch reflects and writes through to Config', (tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
final initial = tester
.widget<SwitchListTile>(find.byKey(const Key('map-enabled-switch')))
.value;
expect(initial, isTrue, reason: 'Config.mapEnabled defaults to true');
await tester.tap(find.byKey(const Key('map-enabled-switch')));
await tester.pumpAndSettle();
expect(config.mapEnabled, isFalse,
reason: 'the switch must write through to Config, not just local state');
});
testWidgets('changing the map switch is visible to other providers immediately',
(tester) async {
// V3-02's acceptance criterion: "changing the map toggle takes effect without an
// app restart". mapEnabledProvider is what trip detail actually reads.
await tester.pumpWidget(host());
await tester.pumpAndSettle();
final container = ProviderScope.containerOf(
tester.element(find.byType(SettingsScreen)),
);
expect(container.read(mapEnabledProvider), isTrue);
await tester.tap(find.byKey(const Key('map-enabled-switch')));
await tester.pumpAndSettle();
expect(container.read(mapEnabledProvider), isFalse);
});
testWidgets('the unit selector writes through to Config', (tester) async {
// The default depends on the test runner's own locale (see config_test.dart), so
// start from an explicit, known value rather than assuming metric.
await config.setUnitSystem(UnitSystem.metric);
await tester.pumpWidget(host());
await tester.pumpAndSettle();
await tester.tap(find.text('Imperial'));
await tester.pumpAndSettle();
expect(config.unitSystem, UnitSystem.imperial);
await tester.tap(find.text('Metric'));
await tester.pumpAndSettle();
expect(config.unitSystem, UnitSystem.metric);
});
testWidgets('the mounted mode switch writes through to Config (V3-05)',
(tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
final initial = tester
.widget<SwitchListTile>(find.byKey(const Key('mounted-mode-switch')))
.value;
expect(initial, isFalse, reason: 'a pocketed ride is still the common case');
await tester.tap(find.byKey(const Key('mounted-mode-switch')));
await tester.pumpAndSettle();
expect(config.mountedMode, isTrue);
});
testWidgets('the crash reporting switch writes through to Config (V3-12)',
(tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
final initial = tester
.widget<SwitchListTile>(find.byKey(const Key('crash-reporting-switch')))
.value;
expect(initial, isFalse, reason: 'off until a privacy policy exists');
await tester.tap(find.byKey(const Key('crash-reporting-switch')));
await tester.pumpAndSettle();
expect(config.crashReportingEnabled, isTrue);
});
/// The Sync section has been pushed below the default test viewport by every section
/// added above it since this suite was first written (V3-05, then V3-12) -- a
/// `ListView` does not mount elements outside its viewport/cache extent, so `find`
/// cannot see them until scrolled into view.
Future<void> scrollToSync(WidgetTester tester) async {
await tester.drag(find.byType(ListView).first, const Offset(0, -600));
await tester.pumpAndSettle();
}
group('upload endpoint', () {
testWidgets('a valid https URL is saved', (tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
await scrollToSync(tester);
await tester.enterText(
find.byKey(const Key('endpoint-field')),
'https://example.test/ingest',
);
await tester.tap(find.byKey(const Key('save-endpoint')));
await tester.pumpAndSettle();
expect(config.uploadEndpoint, 'https://example.test/ingest');
expect(find.text('Endpoint saved'), findsOneWidget);
});
testWidgets('an invalid endpoint is rejected with a readable message, not '
'silently stored', (tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
await scrollToSync(tester);
await tester.enterText(
find.byKey(const Key('endpoint-field')),
'not a url at all',
);
await tester.tap(find.byKey(const Key('save-endpoint')));
await tester.pumpAndSettle();
expect(config.uploadEndpoint, '',
reason: 'garbage input must never reach storage');
expect(find.textContaining('http'), findsWidgets);
});
testWidgets('a non-http scheme is rejected', (tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
await scrollToSync(tester);
await tester.enterText(
find.byKey(const Key('endpoint-field')),
'ftp://example.test/ingest',
);
await tester.tap(find.byKey(const Key('save-endpoint')));
await tester.pumpAndSettle();
expect(config.uploadEndpoint, '');
});
testWidgets('clearing the endpoint is a valid way to disable upload',
(tester) async {
await config.setUploadEndpoint('https://example.test/ingest');
await tester.pumpWidget(host());
await tester.pumpAndSettle();
await scrollToSync(tester);
await tester.enterText(find.byKey(const Key('endpoint-field')), '');
await tester.tap(find.byKey(const Key('save-endpoint')));
await tester.pumpAndSettle();
expect(config.uploadEndpoint, '');
expect(find.text('Upload disabled'), findsOneWidget);
});
});
testWidgets('the device id is shown and a copy control exists', (tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
await scrollToSync(tester);
expect(find.text(config.deviceId), findsOneWidget);
expect(find.byKey(const Key('copy-device-id')), findsOneWidget);
// Tapping must not throw even though no real clipboard exists in the test harness.
await tester.tap(find.byKey(const Key('copy-device-id')));
await tester.pumpAndSettle();
expect(tester.takeException(), isNull);
});
group('Live HUD stats (UI-04)', () {
// The section sits at the bottom of a long ListView -- these rows are not built
// until scrolled into view (a plain `ListView(children:)` still lazily materialises
// via a sliver, same as `.builder`), so every test here scrolls first.
Future<void> scrollTo(WidgetTester tester, Key key) => tester.scrollUntilVisible(
find.byKey(key),
200,
scrollable: find.byType(Scrollable).first,
);
testWidgets('a metric switch reflects and writes through to Config', (tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
await scrollTo(tester, const Key('hud-visible-avgSpeed'));
final initial = tester
.widget<SwitchListTile>(find.byKey(const Key('hud-visible-avgSpeed')))
.value;
expect(initial, isFalse, reason: 'metrics beyond the fixed row start hidden');
await tester.tap(find.byKey(const Key('hud-visible-avgSpeed')));
await tester.pumpAndSettle();
expect(config.hudLayout[HudMetric.avgSpeed]!.visible, isTrue,
reason: 'the switch must write through to Config immediately, not wait '
'for a HUD edit-mode session to end');
});
testWidgets('a metric already visible by default shows as on', (tester) async {
await tester.pumpWidget(host());
await tester.pumpAndSettle();
await scrollTo(tester, const Key('hud-visible-speed'));
final speedSwitch = tester
.widget<SwitchListTile>(find.byKey(const Key('hud-visible-speed')))
.value;
expect(speedSwitch, isTrue);
});
});
testWidgets('shows a spinner rather than crashing while Config is still loading',
(tester) async {
await tester.pumpWidget(
const ProviderScope(
child: MaterialApp(home: SettingsScreen()),
),
);
await tester.pump();
expect(find.byType(CircularProgressIndicator), findsOneWidget);
expect(tester.takeException(), isNull);
});
}